Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73354] Remove JZlib #10123

Merged
merged 1 commit into from
Jan 18, 2025
Merged

[JENKINS-73354] Remove JZlib #10123

merged 1 commit into from
Jan 18, 2025

Conversation

basil
Copy link
Member

@basil basil commented Jan 6, 2025

See JENKINS-73354. JZlib is no longer maintained, and continuing to carry a custom fork is a burden. I have found the Java 7+ GZIPInputStream and GZIPOutputStream classes to work well as a drop-in replacement. No open source Jenkins plugins still use these APIs. There were two proprietary plugins that used these APIs, both of which have now been adapted and released.

Testing done

mvn clean verify and verified the JAR was no longer present in the WAR

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@basil basil added the work-in-progress The PR is under active development, not ready to the final review label Jan 6, 2025
@basil basil force-pushed the jzlib branch 2 times, most recently from 4fb50af to 8df4709 Compare January 8, 2025 01:46
@basil basil added skip-changelog Should not be shown in the changelog and removed work-in-progress The PR is under active development, not ready to the final review labels Jan 17, 2025
@basil basil marked this pull request as ready for review January 17, 2025 18:23
@basil basil requested a review from a team January 17, 2025 18:23
@timja
Copy link
Member

timja commented Jan 17, 2025

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 17, 2025
@basil basil merged commit ab6fd43 into jenkinsci:master Jan 18, 2025
16 checks passed
@basil basil deleted the jzlib branch January 18, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants