[JENKINS-75102] Fix Windows Docker running Windows container with spaces in workspace path

[MarkRx]

Fixed docker windows not working when a running windows containers when the workspace path has both a space and a '@'.

The consecutive double quote escape strategy used by the durable-task-plugin does not work in all cases when passed in to docker exec. Launching the command in the container with call like done here does. Unfortunately changing the durable-task-plugin to use call broke other non-docker use cases and I couldn't find a strategy that handled every case. Additionally, changing the jenkins-wrapper.bat launch command is riskier. I thus opted to handle this case in the logic around decorating the launcher command in the docker-workflow-plugin.

See JENKINS-75102 for more details.

Testing done

A unit test has been created that covers this case. It uses Assume to only run if on Windows, docker is installed, and docker is setup to run Windows containers. The current build process may not be able to run it at this time but it does work locally.

I also tested on a live instance Windows agent running docker using a multibranch pipeline job with branches "main" and "feature/foobar" the later of which tests the '%' character.

pipeline {
    agent {
        label 'docker_windows1809'
    }

    stages {
        stage('Stage') {
            steps {
                ws("C:/jenkins/multi space space") {
                    script {
                        docker.image('microsoft-images-docker.registry.paychex.com/windows/servercore:ltsc2019').inside {
                            bat "echo %cd%"
                        }
                    }
                }
            }
        }
    }
}

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[basil]

Thanks for the PR!