Handling context and docker files separately #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckerfile path. Add missing dependency for unit tests to run
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
Changes proposed on DockerfileImageSelector looks good, but those introducing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in prepareDockerImage() that it would assume that there was Dockerfile int he context root, even if I had specified a custom location for the Dockerfile.
Also I was unable to runt he unit tests without adding that dependency to the pom. Looks like the jenkins-ci artifact brings in jetty but not jetty-util which was needed for the test scaffolding.