fix: Prevent HostedZoneNotEmpty during terraform destroy (#274)

main.tf

@@ -132,6 +132,7 @@ module "dns" {
   tls_email                      = var.tls_email
   enable_external_dns            = var.enable_external_dns
   create_and_configure_subdomain = var.create_and_configure_subdomain
+  force_destroy_subdomain        = var.force_destroy_subdomain
   enable_tls                     = var.enable_tls
   production_letsencrypt         = var.production_letsencrypt
   manage_apex_domain             = var.manage_apex_domain

modules/dns/main.tf

@@ -12,6 +12,7 @@ data "aws_route53_zone" "apex_domain_zone" {
 resource "aws_route53_zone" "subdomain_zone" {
   count = var.create_and_configure_subdomain && var.manage_subdomain ? 1 : 0
   name  = join(".", [var.subdomain, var.apex_domain])
+  force_destroy = var.force_destroy_subdomain
 }
 
 resource "aws_route53_record" "subdomain_ns_delegation" {

modules/dns/variables.tf

@@ -29,6 +29,12 @@ variable "create_and_configure_subdomain" {
   default = false
 }
 
+variable "force_destroy_subdomain" {
+  description = "Flag to determine whether subdomain zone get forcefully destroyed. If set to false, empty the sub domain first in the aws Route 53 console, else terraform destroy will fail with HostedZoneNotEmpty error"
+  type        = bool
+  default     = false
+}
+
 variable "enable_tls" {
   type    = bool
   default = false

variables.tf

@@ -233,6 +233,12 @@ variable "create_and_configure_subdomain" {
   default     = false
 }
 
+variable "force_destroy_subdomain" {
+  description = "Flag to determine whether subdomain zone get forcefully destroyed. If set to false, empty the sub domain first in the aws Route 53 console, else terraform destroy will fail with HostedZoneNotEmpty error"
+  type        = bool
+  default     = false
+}
+
 variable "enable_tls" {
   description = "Flag to enable TLS in the final `jx-requirements.yml` file"
   type        = bool