Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support loadBalancerSourceRanges for hook #1614

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat: support loadBalancerSourceRanges for hook #1614

merged 1 commit into from
Oct 30, 2024

Conversation

msvticket
Copy link
Member

Makes it possible to only allow traffic from certain source ranges.

Typical use case would be if the ingress load balancer is internal and you only have an external network load balancer for the hook.

@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@msvticket
Copy link
Member Author

/cc tomhobson JordanGoasdoue Skisocks

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skisocks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

18 similar comments
@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1614]: [Method Not Allowed]

@jenkins-x-bot jenkins-x-bot merged commit 73b6b5f into main Oct 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skisocks Skisocks Skisocks approved these changes

@JordanGoasdoue JordanGoasdoue Awaiting requested review from JordanGoasdoue

@tomhobson tomhobson Awaiting requested review from tomhobson

Assignees
No one assigned
Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msvticket @jenkins-x-bot @Skisocks