Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat allow pipelinerun rerun to have github status update too #1613

Merged
merged 5 commits into from
Sep 30, 2024
Merged

Feat allow pipelinerun rerun to have github status update too #1613

merged 5 commits into from
Sep 30, 2024

Conversation

JordanGoasdoue
Copy link
Contributor

Allow Github Status Update when Reruning a PipelineRun from Tekton Dashboard

@JordanGoasdoue
Copy link
Contributor Author

/ok-to-test

@JordanGoasdoue JordanGoasdoue changed the title Feat allow pipelinerun rerun to have lighthousejob Feat allow pipelinerun rerun to have github status update too Aug 27, 2024
@JordanGoasdoue
Copy link
Contributor Author

/test pr

msvticket
msvticket requested changes Sep 27, 2024
View reviewed changes
charts/lighthouse/values.yaml Outdated Show resolved Hide resolved
cmd/tektoncontroller/main.go Outdated Show resolved Hide resolved
msvticket
msvticket requested changes Sep 27, 2024
View reviewed changes
charts/lighthouse/values.yaml Outdated Show resolved Hide resolved
@JordanGoasdoue JordanGoasdoue force-pushed the feat-allow-pipelinerun-rerun-to-have-lighthousejob branch from ac9ee08 to ef1eb04 Compare September 27, 2024 12:29
msvticket
msvticket requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@msvticket msvticket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I realised another thing: We do support more than GitHub. So instead of writing "on GitHub" I think something like "at the git provider" would be better

@JordanGoasdoue JordanGoasdoue force-pushed the feat-allow-pipelinerun-rerun-to-have-lighthousejob branch from ef1eb04 to 6d3e32b Compare September 30, 2024 08:18
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 68c9dbe into jenkins-x:main Sep 30, 2024
4 checks passed
@JordanGoasdoue JordanGoasdoue deleted the feat-allow-pipelinerun-rerun-to-have-lighthousejob branch September 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msvticket msvticket msvticket approved these changes

Assignees
No one assigned
Labels
approved ok-to-test size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanGoasdoue @jenkins-x-bot @msvticket