Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix every minute reconsoliation in case of succesfull import #2

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

xdrus
Copy link

@xdrus xdrus commented Sep 24, 2024

Currently controller sync all certificates every minute regardless of updates. This PR removes force-sync every minutes if there were no errors. There are still improvements to be made here, but this helps to ease the pressure on AWS PI in big-ish clusters.

@jenkins-x-bot
Copy link

Hi @xdrus. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@xdrus
Copy link
Author

xdrus commented Sep 24, 2024

/assign msvticket

@msvticket
Copy link
Member

/ok-to-test

@jenkins-x-bot
Copy link

@xdrus: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pr 0a1b132 link /test pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

Copy link
Member

@msvticket msvticket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@msvticket
Copy link
Member

/override pr

@jenkins-x-bot
Copy link

@msvticket: Overrode contexts on behalf of msvticket: pr

In response to this:

/override pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: msvticket

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 21799c6 into jenkins-x:main Sep 26, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants