Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cluster nodes rsg client ID to jx-requirements #39

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

Skisocks
Copy link
Contributor

@Skisocks Skisocks commented May 10, 2023

Populates the cluster nodes resource group client ID added here

jenkins-x/jx#8580

@jenkins-x-bot
Copy link
Contributor

Hi @Skisocks. Thanks for your PR.

I'm waiting for a jenkins-x-terraform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@Skisocks
Copy link
Contributor Author

/cc @msvticket

@msvticket
Copy link
Contributor

I'd say @tomhobson is better suited than me when it comes to reviewing something azure specific.

/cc tomhobson

@Skisocks
Copy link
Contributor Author

Skisocks commented Jul 7, 2023

/cc @tomhobson 😄

@tomhobson
Copy link
Collaborator

/ok-to-test

@tomhobson
Copy link
Collaborator

/approve

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Skisocks
Copy link
Contributor Author

@tomhobson can I get an okay-to-test? 😄

@tomhobson
Copy link
Collaborator

/ok-to-test

@jenkins-x-bot jenkins-x-bot merged commit c4853e8 into jenkins-x-terraform:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants