Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no trigger for tkn prs with no event guid #421

Closed

Conversation

ankitm123
Copy link
Contributor

@ankitm123 ankitm123 commented Feb 23, 2022

Signed-off-by: ankitm123 [email protected]

related to jenkins-x/lighthouse#1420

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ankitm123
You can assign the PR to them by writing /assign @ankitm123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jenkins-x-bot
Copy link
Contributor

@ankitm123: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pr 7eab1a8 link /test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123
Copy link
Contributor Author

/hold

@ankitm123
Copy link
Contributor Author

/close
This wil break manual triggering, as those dont have a guid.

@jenkins-x-bot
Copy link
Contributor

@ankitm123: Closed this PR.

In response to this:

/close
This wil break manual triggering, as those dont have a guid.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants