Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't loose build num #994

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: don't loose build num #994

wants to merge 1 commit into from

Conversation

msvticket
Copy link
Contributor

@msvticket msvticket commented Jan 15, 2025

prevent build num from resetting

The solution consist of 2 parts:

  1. Make sure that all finished pipeline activities are garbage collected from cluster (now some failed ones stay)
  2. If there are no pipeline activities in the cluster: check the logs bucket and extract the latest build num from there

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign msvticket
You can assign the PR to them by writing /assign @msvticket in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msvticket msvticket force-pushed the keep_buildnum branch 2 times, most recently from 6a2d308 to 57168b6 Compare January 15, 2025 14:23
@msvticket
Copy link
Contributor Author

/retest

1 similar comment
@msvticket
Copy link
Contributor Author

/retest

prevent build num from resetting
@jenkins-x-bot
Copy link
Contributor

jenkins-x-bot commented Jan 15, 2025

@msvticket: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pr 8fd40af link /test pr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants