-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: include sparse-checkouts in fake runner with git clone #986
base: main
Are you sure you want to change the base?
chore: include sparse-checkouts in fake runner with git clone #986
Conversation
Hi @GavinPJK. Thanks for your PR. I'm waiting for a jenkins-x-plugins member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate passedIssues Measures |
/cc @Skisocks @msvticket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation of NewFakeRunnerWithGitClone needs to be updated
if command.Name == "git" && len(command.Args) > 1 { | ||
if command.Args[0] == "clone" || command.Args[0] == "sparse-checkout" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have you split up the condition into two if statement?
/ok-to-test |
NewFakeRunnerWithGitClone
uses default command runner forgit sparse-checkout ...
andgit checkout
for local testing