Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optionally allow non-standard namespace #984

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

msvticket
Copy link
Contributor

@msvticket msvticket commented Nov 6, 2024

As of now the boot job (through jx gitops hemfile move) doesn't allow releases to place resources in other namespaces than the one given in the helmfile. This causes problems in some cases, when resource need to be placed in specific system namespace. I describe one example here: kedacore/charts#189 (comment)

It is unclear to me what the purpose of this limitation is. This PR makes this behaviour configurable.

Also annotating resources with release namespace for traceability and improving test.

annotating resources with release namespace for traceability
improving test
@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

Copy link

sonarcloud bot commented Nov 6, 2024

@msvticket
Copy link
Contributor Author

/cc tomhobson JordanGoasdoue Skisocks mentlak0

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Skisocks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [984]: [Method Not Allowed]

@jenkins-x-bot jenkins-x-bot merged commit c836b2c into main Nov 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants