fix: optionally allow non-standard namespace #984
Merged
+208
−78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now the boot job (through
jx gitops hemfile move
) doesn't allow releases to place resources in other namespaces than the one given in the helmfile. This causes problems in some cases, when resource need to be placed in specific system namespace. I describe one example here: kedacore/charts#189 (comment)It is unclear to me what the purpose of this limitation is. This PR makes this behaviour configurable.
Also annotating resources with release namespace for traceability and improving test.