Switch to SSH transport #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jonesbusy
force-pushed
the
feature/ssh-transport
branch
27 times, most recently
from
a503a05 to
51aeb53
Compare
|
Right now all keys are accepted https://github.com/apache/mina-sshd/blob/master/docs/client-setup.md#serverkeyverifier We should validate againts known keys. GitHub provide such keys via API, but it's missing on the java client |
jonesbusy
force-pushed
the
feature/ssh-transport
branch
from
51aeb53 to
b14006e
Compare
|
You're already on it... 😉 |
jonesbusy
force-pushed
the
feature/ssh-transport
branch
9 times, most recently
from
11b000c to
bc80784
Compare
jonesbusy
force-pushed
the
feature/ssh-transport
branch
from
bc80784 to
466a31d
Compare
|
PR finally green |
gounthar
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal for this PR is to allow support for SSH transport on JGit. In order to clone and perform Git operation via SSH
This require to pass the
--ssh-private-keyThis is also some preparation for #460
This also add better support for #318 because the authentication is passed also during fetch command
The PR also add and integration test for the
build-metadatasubcommand and a Git testcontainerThe PR also fixes various bug during testing.
One example is the support of
--maven-local-repowhich was not cutomizable. For example on ci.jenkins.io is different and was breaking the resolution of the core module (which was installed on different locationm2repoof the workspaceThe option is also useful in order to run the tool were the /home/ folder is not writable (typically on container or kubernetes distribution
One improvement is that we miss hub4j/github-api#1996 in order to validate the target GH SSH keys