Fix bug where menus were not positioning correctly with fixed position elements #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the defect, add ment.io to an input or textarea whose ancestor has
position: fixed. The menu will not always appear near the cursor (just under the '@' or target character in the input). To fix this, I check forposition: fixedwhen iterating over each parent object during coordinate calculation. As soon as a fixed element is encountered, then we know to later set the position of the menu tofixedinstead ofabsolute. Additionally, as the user scrolls the window, the menu stays with the input/textarea, which is desired.