Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): allow hyphen values for --text #100

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix(cli): allow hyphen values for --text #100

merged 2 commits into from
Jul 24, 2023

Conversation

jeertmans
Copy link
Owner

Text string can now contain hyphen values.

Closes #99

Text string can now contain hyphen values.

Closes #99
@jeertmans jeertmans added bug Something isn't working cli Related to the CLI labels Jul 24, 2023
@github-actions
Copy link

Thank you for updating CHANGELOG.md! Always feel free to edit it.
See Keep A Changelog for more details.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.35 ⚠️

Comparison is base (7042eda) 24.85% compared to head (029e5c0) 23.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   24.85%   23.50%   -1.35%     
==========================================
  Files           7        7              
  Lines         519      519              
==========================================
- Hits          129      122       -7     
- Misses        390      397       +7     
Impacted Files Coverage Δ
src/lib/check.rs 35.80% <ø> (-1.75%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Benchmark results:

group           before                                  changes
-----           ------                                  -------
basic/large     1.01   724.2±27.02ms    11.2 KB/sec     1.00   718.0±20.08ms    11.3 KB/sec
basic/medium    1.00   233.5±17.85ms     6.0 KB/sec     1.03   239.9±24.94ms     5.9 KB/sec
basic/small     1.00    180.8±7.86ms     4.1 KB/sec     1.18   212.8±38.36ms     3.5 KB/sec
split/large     1.00       3.9±0.22s     2.1 KB/sec     1.26       4.9±0.56s     1677 B/sec
split/medium    1.00  1461.3±132.94ms      988 B/sec    1.09  1590.7±196.81ms      907 B/sec
split/small     1.00   249.8±25.54ms     3.0 KB/sec     1.02   253.5±21.45ms     2.9 KB/sec

@jeertmans jeertmans merged commit db4757e into main Jul 24, 2023
21 of 22 checks passed
@jeertmans jeertmans deleted the hyphen branch July 24, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Related to the CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Markdown frontmatter causes crash
1 participant