Generalize to arbitrary axes. Store metadata in svg attribute to clea… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly remove/update the projection.
|
Hi Sam, Thanks, this seems interesting and useful. I didn't consider this approach, but it makes sense to generalize the plugin like this. I'll have to spend some time with this PR to fully understand it though. I'll try to get back to you before too long. Kind regards, Jeroen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey mate,
I needed to use your tool to produce some technical figures, then I fell down a rabbit hole generalizing it to allow arbitrary axes and arbitrary model rotations.
I figured it would be good to clean it up and send it your way and see if you'd like to merge any of the changes. I haven't updated the docs to reflect my changes but I'd be happy to put a bit of time in to do so if you're keen.
Tested on inkscape 1.2.2.
Cheers,
Sam