SWITCHYARD-2776 Add missing camel-sap converters to TypeConverter file #27
Conversation
|
Can one of the admins verify this patch? |
|
I've just realized that a distro I used for testing contains old camel-sap (6.2.0.redhat-099) which declares converters by package name. There might be a bug when using this converter approach. Please postpone merging the pull request. I will try it with a distro that contains newer camel-sep that declares converters by FQN class names. A fix will be removing TypeConverter file in that case. |
trohovsky
force-pushed
the
SWITCHYARD-2776
branch
from
be8d912
to
27cccfc
Compare
|
I updated the PR, it's ok to merge. TypeConverter file is removed so there is no need to add converter classes into it if some will be added to camel-sap component in future. Type converters are loaded based on camel-sap component's TypeConverter file. |
|
ok to test |
1 similar comment
|
ok to test |
|
@trohovsky We tried merging this with Jenkins, but the error we're seeing is 👍 Caused by: org.apache.camel.RuntimeCamelException: org.apache.camel.TypeConverterLoaderException: Failed to load type converters because of: Cannot find any type converter classes from the following packages: [org.fusesource.camel.component.sap.converter] |
|
The problem is probably caused by an old camel-sap version present in the project: https://github.com/jboss-switchyard/switchyard/blob/master/pom.xml#L64. I tested this with the product, that contains a newer version https://github.com/jboss-fuse/switchyard/blob/2.x.redhat-6-2-x-patch/pom.xml#L61. I will upgrade the version. |
|
ok to test |
1 similar comment
|
ok to test |
|
Can one of the admins verify this patch? |
No description provided.