Update for NServiceBus 8 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* So that ActivityListener in the EndpointFixture can access them
ssweny
reviewed
Oct 11, 2023
| @@ -0,0 +1,17 @@ | |||
| namespace NServiceBus.Extensions.IntegrationTesting | |||
| { | |||
| internal static class NsbActivityNames | |||
There was a problem hiding this comment.
It looks like these fields are unused. Can you remove them?
- OutgoingEventActivityName
- SubscribeActivityName
- UnsubscribeActivityName
jbogard
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this mean it works? 😁 I am by no means an
ActivityListenerexpert, so please let me know if you see anything I could be doing better.