Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter image_url for hyperlinking image #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add parameter image_url for hyperlinking image #27

wants to merge 2 commits into from

Conversation

abinoda
Copy link

@abinoda abinoda commented Jun 20, 2012

No description provided.

@@ -132,8 +133,11 @@
this._custom_timer = time_alive;
}

var image_str = (image != '') ? '<img src="' + image + '" class="gritter-image" />' : '',
class_name = (image != '') ? 'gritter-with-image' : 'gritter-without-image';
var image_str = (image_url != '') ? '<a href="' + image_url + '">' : '';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add (image_url != '' && image != '') to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants