chocolatey-visualstudio.extension: obtain InstallChannelUri from dete…

…cted VS instances GitHub-Issue: GH-7 GH-8 GH-10 GH-26
jberezanski · May 15, 2018 · 3f6250c · 3f6250c
1 parent b444158
commit 3f6250c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/chocolatey-visualstudio.extension/extensions/Get-VSBootstrapperUrlFromChannelManifest.ps1 b/chocolatey-visualstudio.extension/extensions/Get-VSBootstrapperUrlFromChannelManifest.ps1
@@ -26,6 +26,7 @@ function Get-VSBootstrapperUrlFromChannelManifest
         else
         {
             Write-Debug "Package parameters do not contain 'channelUri' or it is empty"
+            # TODO: check $ProductReference.InstallChannelUri
             if ($ProductReference -ne $null -and -not [string]::IsNullOrEmpty($ProductReference.ChannelUri))
             {
                 $manifestUri = $ProductReference.ChannelUri

diff --git a/chocolatey-visualstudio.extension/extensions/Get-VSProductReference.ps1 b/chocolatey-visualstudio.extension/extensions/Get-VSProductReference.ps1
@@ -18,6 +18,7 @@
     $props = @{
         ChannelId = $channelId
         ChannelUri = $null
+        InstallChannelUri = $null
         ProductId = $productId
     }
 

diff --git a/chocolatey-visualstudio.extension/extensions/Get-WillowInstalledProducts.ps1 b/chocolatey-visualstudio.extension/extensions/Get-WillowInstalledProducts.ps1
@@ -25,6 +25,7 @@
     }
     $optionalProductProperties = @{
         nickname = 'nickname'
+        installChannelUri = 'installChannelUri'
     }
     $propertyNameSelector = (($expectedProductProperties.Values + $optionalProductProperties.Values) | ForEach-Object { "($_)" }) -join '|'
     $regexTextBasicInfo = '"(?<name>{0})"\s*:\s*"(?<value>[^\"]+)"' -f $propertyNameSelector

diff --git a/chocolatey-visualstudio.extension/extensions/New-VSProductReference.ps1 b/chocolatey-visualstudio.extension/extensions/New-VSProductReference.ps1
@@ -5,12 +5,14 @@ function New-VSProductReference
     (
         [Parameter(Mandatory = $true)] [string] $ChannelId,
         [Parameter(Mandatory = $true)] [string] $ProductId,
-        [string] $ChannelUri
+        [string] $ChannelUri,
+        [string] $InstallChannelUri
     )
 
     $props = @{
         ChannelId = $ChannelId
         ChannelUri = $ChannelUri
+        InstallChannelUri = $InstallChannelUri
         ProductId = $ProductId
     }
 

diff --git a/chocolatey-visualstudio.extension/extensions/Start-VisualStudioModifyOperation.ps1 b/chocolatey-visualstudio.extension/extensions/Start-VisualStudioModifyOperation.ps1
@@ -194,7 +194,7 @@
 
             $argumentSet = $baseArgumentSet.Clone()
             $argumentSet['installPath'] = $productInfo.installationPath
-            $argumentSet['__internal_productReference'] = New-VSProductReference -ChannelId $productInfo.channelId -ProductId $productInfo.productid -ChannelUri $productInfo.channelUri
+            $argumentSet['__internal_productReference'] = New-VSProductReference -ChannelId $productInfo.channelId -ProductId $productInfo.productid -ChannelUri $productInfo.channelUri -InstallChannelUri $productInfo.installChannelUri
             $argumentSets += $argumentSet
         }
     }