Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Instruction to install django-simple-history before exectuing runtests.py is missing #1294

Conversation

muneeb706
Copy link
Member

Description

Added pip install django-simple-history command under Testing section of Contributing.rst file.

Related Issue

#1293

Motivation and Context

Reader of the document should be able to run tests successfully after going through the instructions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@muneeb706 muneeb706 added the docs label Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f48b53d) 96.87% compared to head (574773b) 96.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
- Coverage   96.87%   96.79%   -0.08%     
==========================================
  Files          23       23              
  Lines        1278     1278              
  Branches      211      211              
==========================================
- Hits         1238     1237       -1     
  Misses         21       21              
- Partials       19       20       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muneeb706 muneeb706 closed this Apr 7, 2024
@muneeb706 muneeb706 deleted the 1293-install-django-simple-history-instruction branch April 7, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant