Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude bots from generated release notes #1231

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Aug 18, 2023

Description

Looking at the last release notes:

https://github.com/jazzband/django-simple-history/releases/tag/3.4.0

Of the 58 bullet points, 29 are by @dependabot and 12 are by @pre-commit-ci, leaving just 17 actual changes by real people, which are very hard to see.

Related Issue

Motivation and Context

We can see what has changed more easily in generated release notes.

How Has This Been Tested?

It's used by other projects:

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1231 (e40609c) into master (2d0fea3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1231   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files          23       23           
  Lines        1271     1271           
  Branches      208      208           
=======================================
  Hits         1234     1234           
  Misses         19       19           
  Partials       18       18           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@theryanwalker theryanwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh neat, didn't know this existed 😄 Thank you!

@ddabble ddabble merged commit 4b22c58 into jazzband:master Aug 18, 2023
19 checks passed
@hugovk hugovk deleted the exclude-bots-from-rel-notes branch August 18, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants