Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use django builtin for determining through field name #1218

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

mjsir911
Copy link
Contributor

@mjsir911 mjsir911 commented Jul 28, 2023

Description

Related Issue

Fixes #1126

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1218 (92c5f05) into master (4b22c58) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1218   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files          23       23           
  Lines        1271     1271           
  Branches      208      208           
=======================================
  Hits         1234     1234           
  Misses         19       19           
  Partials       18       18           
Files Changed Coverage Δ
simple_history/models.py 96.71% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! See below for a few small change requests.

Also, please resolve the merge conflicts in CHANGES.rst 😊

simple_history/models.py Show resolved Hide resolved
simple_history/tests/tests/test_models.py Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 😊

@ddabble ddabble merged commit 78bcd0e into jazzband:master Aug 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating historical records for models with M2M fields to "self" causes FieldError
2 participants