Fix swallowing exceptions and explicitly cap retries in process_response #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the retry logic in
process_response
to not usebreak
infinally
(#745) and to put an explicit cap of 2 attempts to process a response before letting the request continue on through the middleware.The original code also implicitly had a cap of 2 attempts because
finally: break
would have executed regardless of if_process_response
succeeded which meant there would always be either 1 attempt (try
) or 2 attempts (try
andexcept
), never any more. The original likely meant to haveelse: break
to retry forever, but retrying forever is likely undesirable in this situation.Follows up on #140
Fixes #745