Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections support #581

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Collections support #581

merged 2 commits into from
Sep 4, 2024

Conversation

Mogost
Copy link
Member

@Mogost Mogost commented Sep 3, 2024

Fix #574

@sebastianmanger @lpomfrey This PR should address your problem from #574, could you please review/test it?

cc: @ivan-klass @Natim @camilonova

@Mogost Mogost requested a review from Natim September 3, 2024 14:13
@Mogost Mogost self-assigned this Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (ef24fcb) to head (6f95cbe).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
constance/codecs.py 50.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
- Coverage   89.92%   85.41%   -4.51%     
==========================================
  Files          31       21      -10     
  Lines        1032      727     -305     
  Branches      104      130      +26     
==========================================
- Hits          928      621     -307     
- Misses         69       71       +2     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpomfrey
Copy link

lpomfrey commented Sep 3, 2024

We've done some testing and this would seem to fix our problems from #574 👍

@camilonova
Copy link
Member

Looks good to me

@Mogost
Copy link
Member Author

Mogost commented Sep 3, 2024

There's a lack of documentation. If anyone has time to help with it, I would be glad!

@sebastianmanger
Copy link
Contributor

sebastianmanger commented Sep 4, 2024

Thanks a lot! This fully supports my use cases.
As a pure user of the library, I personally would expect something minimal like sebastianmanger@7c24c6d

@Mogost Mogost marked this pull request as ready for review September 4, 2024 09:40
@Mogost
Copy link
Member Author

Mogost commented Sep 4, 2024

Thanks a lot! This fully supports my use cases. As a pure user of the library, I personally would expect something minimal like sebastianmanger@7c24c6d

Thank you. cherry-picked

@Mogost Mogost merged commit bb0dc46 into jazzband:master Sep 4, 2024
9 checks passed
@Mogost Mogost deleted the collection-support branch September 4, 2024 09:41
@Mogost
Copy link
Member Author

Mogost commented Sep 4, 2024

Tagged with 4.1.0 version. Should be released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for collection types (list/tuple/dict/set/etc.)
4 participants