Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migate from setup.py to pyproject.toml & bump tox & declare support for python 3.12 #557

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

Mogost
Copy link
Member

@Mogost Mogost commented Jul 1, 2024

No description provided.

@Mogost Mogost requested a review from camilonova July 1, 2024 14:12
@Mogost Mogost marked this pull request as draft July 1, 2024 14:20
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (ef24fcb) to head (051d3a6).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   89.92%   90.23%   +0.31%     
==========================================
  Files          31       31              
  Lines        1032     1055      +23     
  Branches      104      158      +54     
==========================================
+ Hits          928      952      +24     
+ Misses         69       68       -1     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mogost Mogost marked this pull request as ready for review July 1, 2024 15:25
@Mogost Mogost changed the title migate from setup.py to pyproject.toml migate from setup.py to pyproject.toml & bump tox Jul 1, 2024
Copy link
Contributor

@sergei-iurchenko sergei-iurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Good job!
Previous time a could not fix tox version issue but you did it!

@Mogost
Copy link
Member Author

Mogost commented Jul 2, 2024

Looks good for me. Good job! Previous time a could not fix tox version issue but you did it!

I have seen this and requested your review because of this.

tox.ini Show resolved Hide resolved
@Mogost Mogost changed the title migate from setup.py to pyproject.toml & bump tox migate from setup.py to pyproject.toml & bump tox & declare support for python 3.12 Jul 2, 2024
@Mogost Mogost merged commit 554eedc into jazzband:master Jul 3, 2024
9 checks passed
@Mogost Mogost deleted the pyproject branch July 3, 2024 08:30
@Mogost Mogost mentioned this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants