Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #510 #538

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Fix issue #510 #538

merged 2 commits into from
Feb 5, 2024

Conversation

chrisclark
Copy link
Contributor

Fixes #510

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46fe20d) 90.25% compared to head (6f0bb23) 90.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
- Coverage   90.25%   90.24%   -0.01%     
==========================================
  Files          31       31              
  Lines        1057     1056       -1     
  Branches      157      158       +1     
==========================================
- Hits          954      953       -1     
  Misses         68       68              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@lindsayemarc lindsayemarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I am in favor of this approach compared to simply removing the operationalerror from the except statement. removing the try catch entirely and letting all the errors raise side steps the issue of setting the value when an error is raised.

@chrisclark chrisclark merged commit cb8ae39 into master Feb 5, 2024
15 checks passed
@Anton-Shutik
Copy link

@jezdez Hi, are there any plans to release it to pypi ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data loss using DatabaseBackend when db connection unstable.
3 participants