Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor DatabaseBackend #534

Conversation

sergei-iurchenko
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (bc9707d) 90.21% compared to head (133e685) 92.46%.
Report is 1 commits behind head on master.

Files Patch % Lines
constance/backends/database.py 72.72% 6 Missing ⚠️
constance/base.py 80.76% 3 Missing and 2 partials ⚠️
constance/checks.py 70.00% 2 Missing and 1 partial ⚠️
constance/backends/memory.py 0.00% 1 Missing and 1 partial ⚠️
constance/backends/redisd.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   90.21%   92.46%   +2.24%     
==========================================
  Files          31       31              
  Lines        1053     1022      -31     
  Branches      156      147       -9     
==========================================
- Hits          950      945       -5     
+ Misses         68       49      -19     
+ Partials       35       28       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-iurchenko sergei-iurchenko marked this pull request as draft November 22, 2023 00:53
@camilonova
Copy link
Member

@sergei-iurchenko would you mind to work on this separately and create a PR when ready? (so we can close this)

@camilonova camilonova closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants