Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary variables for autoload sources #242

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

phongnh
Copy link
Contributor

@phongnh phongnh commented Jul 5, 2023

Hi @jayli,

I updated the PR a bit. Because all sources are autoloaded, variables for checks are not necessary. I removed all of them.

Thanks for great plugin. I want to disable loading some unnecessary sources, I find that it is a bit inconsistent in name, so I made a change to unify name structure.

The format will be g:easycomplete_sources_<source-file-name>, for example autoload/easycomplete/sources/ruby.vim, the variable should be g:easycomplete_sources_ruby instead of g:easycomplete_rb.

let g:easycomplete_sources_bash  = 1   "  -->  let g:easycomplete_sources_bash   = 1 
let g:easycomplete_sources_cmake = 1   "  -->  let g:easycomplete_sources_cmake  = 1 
let g:easycomplete_sources_cpp   = 1   "  -->  let g:easycomplete_sources_cpp    = 1 
let g:easycomplete_cs            = 1   "  -->  let g:easycomplete_sources_cs     = 1 
let g:easycomplete_css           = 1   "  -->  let g:easycomplete_sources_css    = 1 
let g:easycomplete_dart          = 1   "  -->  let g:easycomplete_sources_dart   = 1 
let g:easycomplete_sources_deno  = 1   "  -->  let g:easycomplete_sources_deno   = 1 
let g:easycomplete_gopls         = 1   "  -->  let g:easycomplete_sources_go     = 1 
let g:easycomplete_sources_grvy  = 1   "  -->  let g:easycomplete_sources_grvy   = 1 
let g:easycomplete_sources_html  = 1   "  -->  let g:easycomplete_sources_html   = 1 
let g:easycomplete_sources_java  = 1   "  -->  let g:easycomplete_sources_java   = 1 
let g:easycomplete_json          = 1   "  -->  let g:easycomplete_sources_json   = 1 
let g:easycomplete_kotlin        = 1   "  -->  let g:easycomplete_sources_kotlin = 1 
let g:easycomplete_sources_lua   = 1   "  -->  let g:easycomplete_sources_lua    = 1 
let g:easycomplete_nim           = 1   "  -->  let g:easycomplete_sources_nim    = 1 
let g:easycomplete_sources_php   = 1   "  -->  let g:easycomplete_sources_php    = 1 
let g:easycomplete_sources_py    = 1   "  -->  let g:easycomplete_sources_py     = 1 
let g:easycomplete_sources_r     = 1   "  -->  let g:easycomplete_sources_r      = 1 
let g:easycomplete_rb            = 1   "  -->  let g:easycomplete_sources_ruby   = 1 
let g:easycomplete_rust          = 1   "  -->  let g:easycomplete_sources_rust   = 1 
let g:easycomplete_tn            = 1   "  -->  let g:easycomplete_sources_tn     = 1 
let g:easycomplete_sources_ts    = 1   "  -->  let g:easycomplete_sources_ts     = 1 
let g:easycomplete_sources_vim   = 1   "  -->  let g:easycomplete_sources_vim    = 1 
let g:easycomplete_sources_xml   = 1   "  -->  let g:easycomplete_sources_xml    = 1 
let g:easycomplete_sources_yaml  = 1   "  -->  let g:easycomplete_sources_yaml   = 1 

Please help check this PR, and merge it if you find it makes senses, thanks.

@phongnh
Copy link
Contributor Author

phongnh commented Jul 12, 2023

@jayli Any update on this?

@phongnh phongnh changed the title Use consistent prefix 'g:easycomplete_sources_' for loading sources Remove unnecessary variables for autoload sources Jul 12, 2023
@phongnh phongnh force-pushed the master branch 3 times, most recently from 89fe7a1 to 8c7c5f2 Compare July 22, 2023 06:52
@jayli jayli merged commit ce1aacf into jayli:master Nov 27, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants