[better_errors] Add debug info to more Jaxprs and Wrappedfun #26078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnecula
force-pushed
the
debug_info_jaxpr
branch
from
3f3eeaf to
02185e7
Compare
gnecula
force-pushed
the
debug_info_jaxpr
branch
from
02185e7 to
177548e
Compare
… (part 1) We replace those uses with api_util.tracing_debug_info, which means we have to move the call further upstream. But this is better because we have the actual args and kwargs, and we can do a better job, especially for `arg_names`. This is part 1 of a series, for: cond, switch, while, scan, composite, custom_dce, saved_residuals.
We replace uses of `pe.tracing_debug_info` with with `api_util.tracing_debug_info`, which uses the actual args and kwargs, instead of `in_tree` to manufacture fake args and kwargs. This ends up being more accurate, especially for `arg_names`; see changes in debug_info_tests.py. This means that we have to construct the debug info further upstream, before flattening args. This will later help populate debug info in `WrappedFun` and `Jaxpr`. This is part 2 of a series (following jax-ml#26097) for Pallas.
gnecula
force-pushed
the
debug_info_jaxpr
branch
from
177548e to
9b7e598
Compare
We replace uses of `pe.tracing_debug_info` with with `api_util.tracing_debug_info`, which uses the actual args and kwargs, instead of `in_tree` to manufacture fake args and kwargs. This ends up being more accurate, especially for `arg_names`; see changes in debug_info_tests.py. This means that we have to construct the debug info further upstream, before flattening args. This will later help populate debug info in `WrappedFun` and `Jaxpr`. This is part 3 of a series (following jax-ml#26097, jax-ml#26099) for jit, pmap, checkify, custom_dce.
Here we pass debug info in more places, so that it
ends up in more Jaxprs and Tracers. As a result some of the tests
are showing more complete debug info.
There are three kinds of information in the debug info:
* the func_src_info: this is the easiest to keep track of
because all we need is to pass it down. In this chain
of refactorings, I will prioritize having this everywhere.
* the arg_names: this is collected from the function signature,
and it is passed down, but it needs to be adjusted as we add
and remove arguments. This is used when we generate location
information in the lowering and when we explain some leaked
tracers.
* the result_paths: this is the hardest to keep track of, because
you can only read it after tracing. This is also the least useful.
It is used only for locations in the lowering.
To enable progress I will de-prioritize keeping accurate the
arg names and result paths, for now. I relax a safety check in the Jaxpr
constructor that was verifying that arg_names and result_paths
have the proper length. Therefore, I needed to add some checks
where the arg_names and result_paths are used (`safe_arg_names`,
and `safe_result_paths`).
gnecula
force-pushed
the
debug_info_jaxpr
branch
from
9b7e598 to
cfd34b2
Compare
gnecula
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we pass debug info in more places, so that it ends up in more Jaxprs and WrappedFun. As a result some of the tests are showing more complete debug info.
There are three kinds of information in the debug info:
To enable progress I will de-prioritize keeping accurate the arg names and result paths, for now. I relax a safety check in the Jaxpr constructor that was verifying that arg_names and result_paths have the proper length. Therefore, I needed to add some checks where the arg_names and result_paths are used (
safe_arg_names, andsafe_result_paths).