Persist deleteat and deleteafter from upload instructions in mock #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toscott
commented
Jun 26, 2019
| @@ -85,6 +85,9 @@ public ObjectInformation getInfo() { | |||
| uploadInstructions.getContentType() != null ? | |||
| uploadInstructions.getContentType() : | |||
| new ObjectContentType(new MimetypesFileTypeMap().getContentType(getName())); | |||
| this.deleteAt = uploadInstructions.getDeleteAt() != null ? uploadInstructions.getDeleteAt() : | |||
| uploadInstructions.getDeleteAfter() != null ? | |||
| new DeleteAt(System.currentTimeMillis() + uploadInstructions.getDeleteAfter().getExpireAfterSeconds()) : null; | |||
toscott
force-pushed
the
mock_delete_patch
branch
from
ac15738
to
5f5dd93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed some 409 responses due to setting deleteAfter immediately after uploading an object to our swift cluster. Upon transitioning to include the deleteAfter in the upload instructions for an atomic call, we ran into some issues with the mock not persisting the deleteAfter/deleteAt value.
This is just to persist the deleteAfter on the object stored by the mock.