Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member and destructured assignment and rest operator #20

Open
wants to merge 58 commits into
base: develop
Choose a base branch
from
Open

Member and destructured assignment and rest operator #20

wants to merge 58 commits into from

Conversation

jbarrmetro
Copy link
Collaborator

@jbarrmetro jbarrmetro commented Dec 3, 2022 •
edited
Loading

Also assignment to vector indices.

@jbarrmetro jbarrmetro changed the base branch from main to develop December 3, 2022 05:26
@jbarrmetro jbarrmetro changed the title Member and destructured assignment, spread/rest operator, and function rest params Member and destructured assignment, rest operator, and function rest params Dec 3, 2022
@jasonsbarr
Type check tuple pattern assignment
aef54b9
@jasonsbarr
Emit code for tuple type assignment
0eb8fab
@jasonsbarr
Redo handling tuple commas to allow parsing nested tuples
5ea21b3
@jasonsbarr
Fix parsing nested tuple patterns
07ddaff
@jasonsbarr
Type check nested tuple patterns
b56ac7a
@jasonsbarr
Emit code for nested tuple assignment
eb222b4
@jasonsbarr
Make destructuring variable declaration more flexible
9928080
@jasonsbarr
Check for type of types inline instead of with if
3c1d4df
@jasonsbarr
Need to specify that body block of function declaration is of a function
d19c8aa
@jasonsbarr
Actually, just make it return a value if it's not a statement
80dad00
@jasonsbarr
Allow slice expression as LHV
cce5b0f
@jasonsbarr
Flip checking on member and slice expression assignment so error mess…
c57cd0f 
…ages are in the right order, and enable assignment to slice expressions
@jasonsbarr
Make constant value default to false
012aa17
@jasonsbarr
Tuples are always constant
a311b0f
@jasonsbarr
Disallow reassigning props/indices of constant object
4eca363
@jbarrmetro jbarrmetro changed the title Member and destructured assignment, rest operator, and function rest params Member and destructured assignment and rest operator Dec 4, 2022
@jasonsbarr
Add set literal and object pattern ast nodes
2825cca
@jasonsbarr
Refactor checking if identifier is defined into own method
7f61e19
@jasonsbarr
REmove redundant instanceof
2a98f51
@jasonsbarr
Parse set literals
f519732
@jasonsbarr
Make sure emitter takes bound nodes
93eff52
@jasonsbarr
No longer need as string cast
16885fc
@jasonsbarr
Just use parseLHV because if it's an identifier or spread it just ret…
ef0101c 
…urns the node
@jasonsbarr
Use intermediary variable to eliminate as cast
67fe8ad
@jasonsbarr
ga
4a2c27d
@jasonsbarr
Parse object pattern as LHV
d60987d
@jasonsbarr
Add bound object pattern node
4e89be6
@jasonsbarr
Add object pattern case to setNestedDestructuring method for tuple de…
537e3e8 
…structuring
@jasonsbarr
Stub out case for object pattern
c2e428d
@jasonsbarr
Check if identifier is defined for both identifier and spread cases
22b603a
@jasonsbarr
Set variable name and object property type for identifiers in object …
b90bbad 
…pattern
@jasonsbarr
Check on member.kind instead of expr for invalid value
c0f159f
@jasonsbarr
Make sure rest parameter is a valid identifier in parser
45cd21a
@jasonsbarr
Get type for rest parameter in object pattern
b0d0020
@jasonsbarr
Throw error on invalid destructuring pattern
2e9a081
@jasonsbarr
CORRECTLY parse rest param for object destructuring
77d2afc
@jasonsbarr
Check identifier lhv in object pattern assignment
c877971
@jasonsbarr
Check rest parameter in object destructuring assignment
ceeedea
@jasonsbarr
Check object pattern assignment
141a996
@jasonsbarr
Emit code for object pattern destructuring
c38a12f
@jasonsbarr
Set nested destructuring for rest parameter on object pattern
9a7c2b5
@jasonsbarr
Make sure to check if identifiers are defined
059c5ce
@jasonsbarr
Add note
debc44f
@jasonsbarr
Remove redundant code
377c027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbarrmetro @jasonsbarr