Throttle to one request at a time, with 1/5 of a second wait. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… task wait of 1/5 of a second after each translation. Queue of 1 is still to many requests. Need bulk requests in a future release.
thejeff77
commented
Nov 25, 2019
| q.push({'node': node}, function(err) { | ||
| // Precondition, node has been parsed, and xml file has been replaced with translations. | ||
| fs.writeFileSync(filePath, $.xml()); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Code was minimally changed, but structure is different resulting in a confusing PR.
Main difference are lines 169-175 above. This is the new way to add a task, pass data to the predefined processor function. I.E. - pass the node in and add the task to the queue.
|
Do not merge, needs some work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding throttling via async lib queue functionality. Adding sleep for task wait of 1/5 of a second after each translation. Queue of 1 is still to many requests. Need bulk requests in a future release.
Using a queue of more than 1 would give me rate-limit-exceeded. Without the sleep, it also goes too fast.
Now its still really really fast, it just doesn't break.