-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with updated PW3 instructions #493
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aec9325
Update README.md with updated PW3 instructions
pavandave 1570018
Move PW3 helps to troubleshooting section
jasonacox 214cd24
Setup adjustments for PW3 #492 and write permission check in setup.sh…
jasonacox f3fc4cb
v4.4.5
jasonacox c3e80e7
Update to latest pypowerwall
jasonacox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
4.4.4 | ||
4.4.5 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,6 +35,17 @@ if [ "$EUID" -eq 0 ]; then | |
exit 1 | ||
fi | ||
|
||
# Verify user has write permission to this directory | ||
if [ ! -w . ]; then | ||
echo "ERROR: Your user ($USER) does not have write permission to this directory." | ||
echo "" | ||
ls -ld "$(pwd)" | ||
echo "" | ||
echo "Please fix file permissions and try again." | ||
echo "" | ||
exit 1 | ||
fi | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm combining an enhancement based on #494 to help with installs where the user does not have write access to their local directory. |
||
# Verify user in docker group (not required for Windows Git Bash) | ||
if ! type winpty > /dev/null 2>&1; then | ||
if ! $(id -Gn 2>/dev/null | grep -qw "docker"); then | ||
|
@@ -287,13 +298,13 @@ if [ -f ${PW_ENV_FILE} ]; then | |
fi | ||
fi | ||
|
||
# Function to test an IP to see if it returns a ping | ||
# Function to test a GW IP to see if it responds | ||
function test_ip() { | ||
local IP=$1 | ||
if [ -z "${IP}" ]; then | ||
return 1 | ||
fi | ||
if curl -k --head --connect-timeout 1 --silent https://${IP} > /dev/null 2>&1; then | ||
if curl -k --head --connect-timeout 2 --silent https://${IP} > /dev/null 2>&1; then | ||
return 0 | ||
else | ||
return 1 | ||
|
@@ -337,15 +348,28 @@ if [ ! -f ${PW_ENV_FILE} ]; then | |
else | ||
PW_GW_PWD="${PW}" | ||
fi | ||
echo "" | ||
# Double check the user doesn't have a Powerwall 3 | ||
if [ $pw3 -ne 1 ]; then | ||
read -p 'Do you have a Powerwall 3? [y/N] ' response | ||
if [[ "$response" =~ ^([yY][eE][sS]|[yY])$ ]]; then | ||
pw3=1 | ||
PASSWORD="" | ||
EMAIL="" | ||
fi | ||
echo "" | ||
fi | ||
fi | ||
else | ||
echo "The Powerwall Gateway (192.168.91.1) is not found on your LAN." | ||
if [ $pw3 -eq 1 ]; then | ||
echo "" | ||
echo "Powerwall 3 requires access to the Gateway for pull local data." | ||
echo "Ensure the Gateway is connected to your host and rerun setup." | ||
echo "Ensure the Gateway can be reached by your host and rerun setup." | ||
echo "Alternatively you can select a Tesla Cloud mode." | ||
echo "" | ||
echo "Test: curl -k --head https://192.168.91.1" | ||
echo "" | ||
exit 1 | ||
fi | ||
echo "Standard dashboard metrics will work but Extended data (vitals) via TEDAPI" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This updates us to the next version.