Holstein #21
Merged
Holstein #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to save and load material data. Other bits and pieces.
…phonon freq. normalisation). Corrected factor of 2 in Holstein el-ph matrix. Removed some questionable `@fastmath` macros causing some errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eschew of changes since March, mostly related to the parabolic Holstein model. Optimised some of the code to maximum efficiency and accuracy of some numerical integrals. Corrected the addition of units to Unitful polaron properties (like mobility for the Holstein model). Some small bug fixes such as missing arguments in functions. Finally, updated tests to match the new code.