tests: fix tests for APIKeys since we renamed 'name' to 'descr'

jaredhendrickson13 · Nov 10, 2023 · 95d2dec · 95d2dec
1 parent 1a1518d
commit 95d2dec
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/pfSense-pkg-API/files/etc/inc/api/tests/APIModelsAPIKeyTestCase.inc b/pfSense-pkg-API/files/etc/inc/api/tests/APIModelsAPIKeyTestCase.inc
@@ -18,13 +18,15 @@ class APIModelsAPIKeyTestCase extends TestCase
             code: 400,
             callable: function () {
                 $key = new APIKey();
+                $key->client->username = "not_an_existing_user";
                 $key->validate_username("not_an_existing_user");
             }
         );
 
         $this->assert_does_not_throw(
             callable: function () {
                 $key = new APIKey();
+                $key->client->username = "admin";
                 $key->validate_username("admin");
             }
         );
@@ -35,7 +37,10 @@ class APIModelsAPIKeyTestCase extends TestCase
      */
     public function test_key_and_hash_populated_after_creation() {
         # Construct an APIKey model object to test with
-        $key = new APIKey(representation_data: ["name" => "test", "username" => "admin"]);
+        $key = new APIKey();
+
+        # Assign the client an actual username since it's required 
+        $key->client->username = "admin";
 
         # Ensure there is no `key` or `hash` value set before creation.
         $this->assert_is_empty($key->key->value);
@@ -65,7 +70,8 @@ class APIModelsAPIKeyTestCase extends TestCase
      */
     public function test_authenticate() {
         # Construct an APIKey model object to test with
-        $key = new APIKey(representation_data: ["name" => "test", "username" => "admin"]);
+        $key = new APIKey();
+        $key->client->username = "admin";
         $key->create();
 
         # Ensure we can authenticate using the actual `key`
@@ -84,10 +90,11 @@ class APIModelsAPIKeyTestCase extends TestCase
             response_id: "API_KEY_CANNOT_BE_UPDATED",
             code: 500,
             callable: function () {
-                $key = new APIKey(representation_data: ["name" => "test", "username" => "admin"]);
+                $key = new APIKey();
+                $key->client->username = "admin";
                 $key->create();
                 $key->update();
             }
         );
     }
-}
+}