remove db engine convert_unicode argument per SQLALchemy 1.3 upgrade …

…guide
jantman · Jan 25, 2020 · 2db9cd1 · 2db9cd1
1 parent 5345338
commit 2db9cd1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -22,6 +22,8 @@ Unreleased Changes
   * Upgrade Jinja2 from 2.10 to 2.10.3 for `CVE-2019-10906 <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-10906>`_.
   * Upgrade to latest versions for: alembic, Babel, beautifulsoup4, cffi, httplib2, hvac, idna, keyring, lxml, requests, SQLAlchemy-Utc.
 
+* Remove ``convert_unicode`` argument from SQLAlchemy DB engine arguments per SQLAlchemy 1.3 upgrade guide / `SQLAlchemy #4393 <https://github.com/sqlalchemy/sqlalchemy/issues/4393>`_.
+
 1.0.0 (2018-07-07)
 ------------------
 

diff --git a/biweeklybudget/db.py b/biweeklybudget/db.py
@@ -75,7 +75,6 @@
 warnings.simplefilter('error', category=Warning)
 
 engine_args = {
-    'convert_unicode': True,
     'echo': echo,
     'pool_recycle': 3600
 }

diff --git a/biweeklybudget/tests/conftest.py b/biweeklybudget/tests/conftest.py
@@ -104,7 +104,7 @@ def get_db_engine():
             os.environ['DB_CONNSTRING'] = connstr
         biweeklybudget.settings.DB_CONNSTRING = connstr
         _DB_ENGINE = create_engine(
-            connstr, convert_unicode=True, echo=False,
+            connstr, echo=False,
             connect_args={
                 'sql_mode': 'STRICT_ALL_TABLES,NO_ZERO_DATE,'
                             'NO_ZERO_IN_DATE,ERROR_FOR_DIVISION_BY_ZERO,'