Escape ghprbPullTitle properly #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
mortax
reviewed
Jul 29, 2017
| @@ -345,7 +345,7 @@ public void run() { | |||
| values.add(new StringParameterValue("ghprbPullAuthorLoginMention", "@" + cause.getPullRequestAuthor().getLogin())); | |||
|
|
|||
| values.add(new StringParameterValue("ghprbPullDescription", escapeText(String.valueOf(cause.getShortDescription())))); | |||
| values.add(new StringParameterValue("ghprbPullTitle", String.valueOf(cause.getTitle()))); | |||
| values.add(new StringParameterValue("ghprbPullTitle", escapeText(String.valueOf(cause.getTitle())))); | |||
| values.add(new StringParameterValue("ghprbPullLink", String.valueOf(cause.getUrl()))); | |||
| values.add(new StringParameterValue("ghprbPullLongDescription", escapeText(String.valueOf(cause.getDescription())))); | |||
There was a problem hiding this comment.
i think the same thing needs to be done here. my descriptions often contain `` escaped quotes which cause shell failures.
|
👍 i would love to see this PR merged (plus my suggestions to do the same thing for the description)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment on https://issues.jenkins-ci.org/browse/JENKINS-30947