-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change .gpla format to binary, improving performance massively #236
Conversation
Platforms and software testedList any platforms tested. E.g. Windows or macOS Also list any DAWs you are using to test. E.g. Ableton, Reaper, Logic. Testing performedDescribe in detail any testing you've performed that is specific to the feature or bugfix this PR addresses. Testing checklist
|
Thanks for the PR this is awesome work! Do you mind filling out the template above for testing so I have an idea of what has been tested? Not everything is relevant to this PR so just remove it if you think it's not relevant. Once you've filled out the template I'll try and do a proper review :) |
Platforms and software tested Testing performed Testing checklist
|
Fixes #239 I need to do a bit of testing to ensure stability, but this fix makes the frame update to the newest frame in the queue instead of the next frame in the queue, ensuring that the animation is at most 1 audio block late. This might be possible to reduce to 0 blocks, I'll see if I can make that work soon. |
0 blocks doesn't appear to be easily possible without significant rewrite of the audio processing code, so I'll leave it like this for now. Beginning testing. |
...or I may have forgotten to enable plugin copy so I wasn't actually testing the changes 🤦 |
Platforms and software testedWindows - VST3 in Ableton, Standalone Testing performedI have tested a very large GPLA file at high framerate along with the default OBJ file, and everything works as before except the frames now update when stale so there's not a large delay before the frame updates when starting a new MIDI note after some time not playing the previous one. Testing checklist
|
Strange sounds are happening, I think I know what's wrong though |
Fixed |
Switched to a new PR, but code is largely the same. Regardless, I'm closing this PR now. |
As described above, the .gpla file is now a binary format that performs far better on save and load. Technically it's base64 encoded so it still works with the file save and load functions built into osci-render, but the decoded data is pure binary.