-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new testsuite to check types of System.Posix.Types #59
Open
mmhat
wants to merge
16
commits into
jacobstanley:master
Choose a base branch
from
mmhat:check-types-testsuite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also define LinkCount/UserID/GroupID in terms of the new types. Expose constructors of all newtypes.
Thanks for the PR; please consider re-opening at the new repo location https://github.com/haskell-pkg-janitors/unix-compat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new testsuite
unix-compat-check-types
. Its purpose is to track the types of the numerous type and newtype declarations ofSystem.Posix.Types
on different OSs. Themain
function of that testsuite is a stub, success is indicated by a successful compilation of the testsuite itself. In addition to that itUserID
/GroupID
/LinkCount
in terms ofCUid
/CGid
/CNlink
like it is done inSystem.Posix.Types
.System.PosixCompat.Types
.