-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Remaining string modules #178
Conversation
1f5397a
to
061993e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just needs a quick jsdoc fix and it should be good to merge.
Also, this might close #92, but not completely sure.
*/ | ||
export type UUIDS<Version extends UUIDVersion> = SchemaExt<string, UUID<Version>> | ||
|
||
export const UUID = <Version extends UUIDVersion>(version: Version): UUIDS<Version> => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need a jsdoc here for docs-ts, though jsdoc will be merged in vscode with all exports with identical names (not sure how it works)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
} | ||
}) | ||
|
||
test('arbitrary ranges', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tests!
061993e
to
19917ea
Compare
it does not close #92 |
19917ea
to
e2ff9b9
Compare
e2ff9b9
to
0b37889
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
HslColor
(closesHslColor
#174)RGB
(closesRGB
#175)UUID
(closesUUID
#176)LatLong
(closesLatLong
#177)UUID
module (the version is now part of the brand) (closes Fix branding #170)src/string
since that folder no longer exists and we have no plans to ever remake it (new modules should beWithX
extensions)integerRange
for pattern builder! wooregexFromPattern(PB.integerRange(12, 31))
=> (something like)/^(1[2-9]|2\d|3[0-1])$/
apologies for the length, but the commits should be mostly self-contained.