Refactor Remaining string modules #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeate
force-pushed
the
remaining-string-modules
branch
from
1f5397a
to
061993e
Compare
jacob-alford
previously approved these changes
Nov 12, 2022
There was a problem hiding this comment.
Looks great! Just needs a quick jsdoc fix and it should be good to merge.
Also, this might close #92, but not completely sure.
| */ | ||
| export type UUIDS<Version extends UUIDVersion> = SchemaExt<string, UUID<Version>> | ||
|
|
||
| export const UUID = <Version extends UUIDVersion>(version: Version): UUIDS<Version> => |
There was a problem hiding this comment.
You might need a jsdoc here for docs-ts, though jsdoc will be merged in vscode with all exports with identical names (not sure how it works)
| } | ||
| }) | ||
|
|
||
| test('arbitrary ranges', () => { |
skeate
force-pushed
the
remaining-string-modules
branch
from
061993e
to
19917ea
Compare
|
it does not close #92 |
skeate
force-pushed
the
remaining-string-modules
branch
from
19917ea
to
e2ff9b9
Compare
skeate
force-pushed
the
remaining-string-modules
branch
from
e2ff9b9
to
0b37889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HslColor(closesHslColor#174)RGB(closesRGB#175)UUID(closesUUID#176)LatLong(closesLatLong#177)UUIDmodule (the version is now part of the brand) (closes Fix branding #170)src/stringsince that folder no longer exists and we have no plans to ever remake it (new modules should beWithXextensions)integerRangefor pattern builder! wooregexFromPattern(PB.integerRange(12, 31))=> (something like)/^(1[2-9]|2\d|3[0-1])$/apologies for the length, but the commits should be mostly self-contained.