Add logger #42
Merged
Add logger #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brandon Qi <[email protected]>
Co-authored-by: Brandon Qi <[email protected]>
adamhutchings
requested changes
Oct 9, 2023
core/internal/logger.hpp
Outdated
| enum Severity get_severity(); | ||
| std::string get_message(); | ||
|
|
||
| Log(); |
There was a problem hiding this comment.
I just remembered that you can do default parameters just like in Python rather than overloading, so we should probably do that instead.
core/internal/logger.hpp
Outdated
|
|
||
| public: | ||
| static Logger *Instance(); | ||
| static Logger *Instance(enum Severity s); |
There was a problem hiding this comment.
Same thing down here.
| } | ||
|
|
||
| std::unique_ptr<Vector> Matrix::multiply(std::unique_ptr<Vector> in) { | ||
|
|
||
| if (in->get_size() != this->n) { | ||
| std::cout << "Tried to multiply a vector of size " << in->get_size() | ||
| << " with a matrix containing " << this->n << " columns." << std::endl; | ||
| LOGGER->log(Log(WARN) << "Tried to multiply a vector of size " |
There was a problem hiding this comment.
Is this a warning? It seems like an error. (Also with the one for vectors below). What do you think?
core/src/math/vector.cpp
Outdated
| } | ||
| this->entries[pos] = val; | ||
| } | ||
|
|
||
| void Vector::add_entry(int pos, double val) { | ||
| if (pos < 0 || pos >= this->length) { | ||
| std::cout << "Position " << pos << " out of bounds." << std::endl; | ||
| LOGGER->log(Log(WARN) << "Position " << pos << " out of bounds.\n"); |
There was a problem hiding this comment.
Why is this a WARN when the other two are ERR?
adamhutchings
approved these changes
Oct 9, 2023
Sophon96
reviewed
Oct 9, 2023
|
Good to merge? |
|
I think so! |
|
Somehow CI passed but this PR doesn't build |
|
And #45 should fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18 and fixes #19
TODO:
- [ ] Make internal namespaceThis would mean that Log would have to be internal::log and WARN would have to be internal::WARN, which is a lot to just log. I'm not sure if this should be done.