Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(matrix): add row and col getters #37

Merged
merged 2 commits into from
Oct 8, 2023
Merged

feat(matrix): add row and col getters #37

merged 2 commits into from
Oct 8, 2023

Conversation

Sophon96
Copy link
Member

@Sophon96 Sophon96 commented Oct 8, 2023

No description provided.

adamhutchings
adamhutchings requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@adamhutchings adamhutchings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name is slightly ambiguous because to me, at least, it read like it was returning the rows and columns themselves instead of the numbers of them. Maybe make the names something more like get_row_number or similar?

@Sophon96 Sophon96 merged commit 63a2650 into jabacat:main Oct 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamhutchings adamhutchings adamhutchings approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sophon96 @adamhutchings