Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setup and requirements files with pyproject.toml #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacklinke
Copy link

- Fixes # 135
- Move version number into toml file
- Not including poetry.lock per Poetry recommendations that it is not needed for libraries (https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control)
- Also fixes minor sphinx block rendering issue
@izimobil
Copy link
Owner

izimobil commented Feb 4, 2023

Hi @jacklinke , thanks for your contribution !
I'm really not sure I want to force the usage of poetry.
Correct me if I'm wrong (I've never used poetry), but this would break current installations that use pip.

Could it be possible to keep pip support along with poetry ?

@matthewhegarty
Copy link
Collaborator

I agree with @izimobil - could we keep pip support?

@browniebroke
Copy link
Contributor

Could it be possible to keep pip support along with poetry ?

If you mean to keep the ability to do pip install against the repo, that still works due to the build backend:

https://github.com/jacklinke/django-rest-framework-datatables/blob/9b7bb47d280db56536f6d1caff6ac224da42b4e9/pyproject.toml#L59-L61

You can test it with:

pip install https://github.com/jacklinke/django-rest-framework-datatables/archive/add_pyproject_toml.zip

If you really don't like Poetry (which is fine, it's opinionated and not for everyone), there is an alternative to use pyproject.toml using setuptools, which you might find closer to the official standard.

@izimobil
Copy link
Owner

Could it be possible to keep pip support along with poetry ?

If you mean to keep the ability to do pip install against the repo, that still works due to the build backend:

https://github.com/jacklinke/django-rest-framework-datatables/blob/9b7bb47d280db56536f6d1caff6ac224da42b4e9/pyproject.toml#L59-L61

You can test it with:

pip install https://github.com/jacklinke/django-rest-framework-datatables/archive/add_pyproject_toml.zip

If you really don't like Poetry (which is fine, it's opinionated and not for everyone), there is an alternative to use pyproject.toml using setuptools, which you might find closer to the official standard.

To be honest, I don't know / never used Poetry, but reading the proposed pyproject.toml gives me headaches ;)
Would adding something like this (copied from Django's pyproject.toml) be sufficient to address the original issue #135 ?

[build-system]
requires = ['setuptools>=40.8.0']
build-backend = 'setuptools.build_meta'

Maybe I'm getting old, but "If it ain't broke, don't fix it" comes to my mind...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecation warning due to no pyproject.toml
4 participants