Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui update #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ui update #29

wants to merge 2 commits into from

Conversation

dtan
Copy link

@dtan dtan commented Jun 2, 2013

this is a minor change, but I applied the "symphony red" to the hover state of the "removing asset" button. I think this will give a better visual indicator similar to when you're about to delete something in the symphony ui. I also updated the p.error color to the same

…n removing an asset to give a better visual indicator
@iwyg
Copy link
Owner

iwyg commented Jun 2, 2013

can you put this directly into the .less file? Otherwise it will be overwritten for the next build.

@dtan
Copy link
Author

dtan commented Jun 2, 2013

sure. I tried running the dev/build.sh file after making my changes in the .less file, but it didn't seem to compile it correctly. Is there something i'm missing to make the .less files build correctly? Just to run this by you as well, i changed three spots:

  1. Added @symphony_red: #dd4422;
  2. Changed the .filemanager .btn &:hover background color from darken(@bg_grey, 8%) to @symphony_red
  3. Changed p.error color of red to @symphony_red

I mean, it's pretty straight forward, but I feel like i'm missing something with the build process.

@iwyg
Copy link
Owner

iwyg commented Jun 2, 2013

oh, yes, my bad. The less files are not compiled within the build script. That's just r.js. You'll have to compile them manually. You can just submit the less file, and I'll compile it during the next build.

@dtan
Copy link
Author

dtan commented Jun 2, 2013

ok, i updated the less file but did not test with a build since i don't have less set up right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants