Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose a FormFragment component for use in complex components #129

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

expose a FormFragment component for use in complex components #129

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6614d18
expose a FormFragment component for use in complex components
scamden Jul 15, 2023
0bb22cd
add more test cases for FormFragment, support ZodLazy, allow configur…
scamden Jul 18, 2023
6c845f8
use FormFragmentField instead of customizing name to controller, also…
scamden Jul 19, 2023
8b662ab
one more test showing that we can skip levels
scamden Jul 19, 2023
4c4754f
add test condition to ensure editing actually affects the form values
scamden Jul 19, 2023
571a60c
use the passed complex props and add one case of exposing the proptyp…
scamden Aug 1, 2023
88067f1
early null for no error and remove debug
scamden Aug 1, 2023
5390602
Merge branch 'main' into sterling-07-14-expose_a_FormFragment_compone…
scamden Aug 1, 2023
9f8f194
export the new function
scamden Aug 1, 2023
55cb810
export useMaybeFieldName as well
scamden Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jest.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
/** @type {import('ts-jest').JestConfigWithTsJest} */
module.exports = {
preset: "ts-jest",
testTimeout: process.env.JEST_TIMEOUT
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice for debugging

? parseInt(process.env.JEST_TIMEOUT)
: undefined,
testEnvironment: "jsdom",
testPathIgnorePatterns: ["utils", "lib"],
restoreMocks: true,
Expand Down
9 changes: 7 additions & 2 deletions src/FieldContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ export function FieldContextProvider({
);
}

export function useMaybeFieldName() {
Copy link
Collaborator Author

@scamden scamden Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us automatically derive the name from context if there are any Fields already provided above us

const context = useContext(FieldContext);
return context?.name;
}

function useContextProt(name: string) {
const context = useContext(FieldContext);
if (!context)
Expand Down Expand Up @@ -106,7 +111,7 @@ export function useTsController<FieldType extends any>() {
? DeepPartial<FieldType> | undefined
: FieldType | undefined;
// Just gives better types to useController
const controller = useController(context) as any as Omit<
const controller = useController(context) as unknown as Omit<
UseControllerReturn,
"field"
> & {
Expand Down Expand Up @@ -471,4 +476,4 @@ export function useNumberFieldInfo() {
},
"useNumberFieldInfo"
);
}
}
Loading