-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information for rust-bitcode #5
Conversation
The installation instructions were missing for the iOS part. Also some of the import parts in the xcode project were wrong.
@@ -1,15 +1,15 @@ | |||
#!/bin/bash | |||
|
|||
# Ensure that `cargo` is in PATH, using the default location. | |||
export PATH="$PATH:${HOME}/.cargo/bin" | |||
. "$HOME/.cargo/env" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -106,12 +106,26 @@ rustup target add aarch64-linux-android armv7-linux-androideabi x86_64-linux-and | |||
|
|||
## iOS specific steps | |||
|
|||
- Add targets | |||
- Install rust 1.46.0 with MacOSX binary support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macOS :)
It works, thanks 👍! can we can do something to not have to specify the version in the app's script (and ideally use a placeholder in the instructions too)? |
Did you test it on a clean repo? I had to compile it manually once for all the rust libraries, and then let Xcode do the compiling of the main rust code and the linking. With regard to multiple versions, this might be a bit tricky. The
|
Hmm I had to run cargo +ios-arm64-1.46.0 build --target aarch64-apple-ios --release --lib
cargo build --target=x86_64-apple-ios --release directly on the terminal once.. it seems that there are linker issues when the script is executed from Xcode.
Maybe related? TimNN/cargo-lipo#41 Let's skip the version thing for now, rust-bitcode's last stable release is from about 6 months ago, so not that much of an issue. |
Thanks for your contribution! |
The installation instructions were missing for the iOS part.
Also some of the import parts in the xcode project were wrong.
Closes #4