-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ different template users for each website #993
base: 11.0
Are you sure you want to change the base?
⚡ different template users for each website #993
Conversation
Привет! Запусти пожалуйста у себя в репозитории команду |
3f94df0
to
91ba67d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that auth_signup can be in depedencies of this module. I'd suggest to inherit _signup_create_user
method. In that case we don't need to add auth_signup to dependencies. But it doesn't fit the purpose of the module "Website switcher in backend". Proper place for the feature would be https://github.com/itpp-labs/website-addons/tree/11.0/website_multi_company_portal or a new module auth_signup_multi_website
@api.multi | ||
def create_new_template_user_id(self): | ||
IrConfigParameter = self.env["ir.config_parameter"].sudo() | ||
user_id = IrConfigParameter.get_param("auth_signup.template_user_id", "False") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth_signup is not in depedencies of web_website module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right, forgot to test this case. Website module is in dependencies and it uses such structures but they won't lead to an error.
https://github.com/odoo/odoo/blob/11.0/addons/website/models/res_config_settings.py#L94
Should i do a new auth_signup_multi_website module then? It is a more general approach and allows to use built-in methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new module auth_signup_multi_website should be fine.
FYI: odoo 13 already support this feature
No description provided.