-
Notifications
You must be signed in to change notification settings - Fork 44
CI: allow lint and short tests for everyone #695
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 109 109
Lines 9943 9943
=======================================
Hits 8224 8224
Misses 1719 1719 ☔ View full report in Codecov by Sentry. |
… for framework tests
GITHUB_USERNAME: ${{ secrets.GH_USERNAME }} | ||
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} | ||
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
GITHUB_MATRIX_OS: ${{ matrix.os }} | ||
GITHUB_MATRIX_PYTHON: ${{ matrix.python }} | ||
BITBUCKET_USERNAME: ${{ secrets.BITBUCKET_USERNAME }} | ||
BITBUCKET_PASSWORD: ${{ secrets.BITBUCKET_PASSWORD }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to recall how we ended up with this authorize
step, and IIRC, it was the case that CI/CD doesn't run for external contributors at all because GH doesn't allow them to use secrets we put to the repo. If that's true, we need to actually separate tests to two parts: one that requires secrets, and the other that doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should've moved this back to draft, my bad sorry. I moved attention elsewhere but I'll catch up with you again before coming back to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this ^
addresses: #330 (maybe partially, at least)
Allow basic checks and short ci tests without approval. need approvals for framework tests