This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
CI: allow lint and short tests for everyone #695
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omesser
added
the
🏡 housekeeping
omesser
changed the title
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 109 109
Lines 9943 9943
=======================================
Hits 8224 8224
Misses 1719 1719 ☔ View full report in Codecov by Sentry. |
… for framework tests
aguschin
approved these changes
Aug 21, 2023
aguschin
reviewed
Aug 21, 2023
Comment on lines
+97
to
+104
| GITHUB_USERNAME: ${{ secrets.GH_USERNAME }} | ||
| GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} | ||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| GITHUB_MATRIX_OS: ${{ matrix.os }} | ||
| GITHUB_MATRIX_PYTHON: ${{ matrix.python }} | ||
| BITBUCKET_USERNAME: ${{ secrets.BITBUCKET_USERNAME }} | ||
| BITBUCKET_PASSWORD: ${{ secrets.BITBUCKET_PASSWORD }} |
There was a problem hiding this comment.
I'm trying to recall how we ended up with this authorize step, and IIRC, it was the case that CI/CD doesn't run for external contributors at all because GH doesn't allow them to use secrets we put to the repo. If that's true, we need to actually separate tests to two parts: one that requires secrets, and the other that doesn't.
There was a problem hiding this comment.
I should've moved this back to draft, my bad sorry. I moved attention elsewhere but I'll catch up with you again before coming back to this.
aguschin
suggested changes
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses: #330 (maybe partially, at least)
Allow basic checks and short ci tests without approval. need approvals for framework tests