Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Requirement version resolution fix #694

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

omesser
Copy link
Contributor

@omesser omesser commented Jul 13, 2023

Use importlib.metadata's distribution to extract package versions
closes: #688

@omesser omesser requested a review from a team as a code owner July 13, 2023 20:08
@omesser omesser temporarily deployed to external July 13, 2023 20:11 — with GitHub Actions Inactive
@omesser omesser added bugfix Fixing bugs (for PRs mostly) requirements Finding requirements and dependencies needed to properly serialize objects labels Jul 13, 2023
@omesser omesser changed the title Package version resolution fix - use importlib metadata distribution to extraction pacakge version Requirement version resolution fix Jul 13, 2023
@omesser omesser temporarily deployed to external July 13, 2023 20:20 — with GitHub Actions Inactive
@omesser omesser temporarily deployed to external July 13, 2023 20:41 — with GitHub Actions Inactive
@omesser omesser temporarily deployed to external July 13, 2023 20:44 — with GitHub Actions Inactive
@omesser omesser temporarily deployed to external July 13, 2023 20:50 — with GitHub Actions Inactive
@omesser omesser temporarily deployed to external July 13, 2023 21:33 — with GitHub Actions Inactive
@omesser omesser temporarily deployed to external July 13, 2023 21:39 — with GitHub Actions Inactive
@omesser omesser temporarily deployed to external July 14, 2023 11:03 — with GitHub Actions Inactive
@omesser omesser closed this Jul 21, 2023
@omesser omesser reopened this Jul 21, 2023
@omesser omesser temporarily deployed to external July 21, 2023 15:30 — with GitHub Actions Inactive
@omesser omesser closed this Jul 21, 2023
@omesser omesser reopened this Jul 21, 2023
@omesser omesser temporarily deployed to external July 21, 2023 22:52 — with GitHub Actions Inactive
@omesser omesser marked this pull request as draft July 22, 2023 22:00
@omesser omesser temporarily deployed to external July 31, 2023 10:04 — with GitHub Actions Inactive
@omesser omesser requested a review from mike0sv July 31, 2023 14:11
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.07% ⚠️

Comparison is base (f2a5847) 82.71% compared to head (2059f21) 82.64%.
Report is 2 commits behind head on main.

❗ Current head 2059f21 differs from pull request most recent head 02232ca. Consider uploading reports for the commit 02232ca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #694      +/-   ##
==========================================
- Coverage   82.71%   82.64%   -0.07%     
==========================================
  Files         109      109              
  Lines        9943     9948       +5     
==========================================
- Hits         8224     8222       -2     
- Misses       1719     1726       +7     
Files Changed Coverage Δ
mlem/core/hooks.py 95.08% <ø> (ø)
mlem/utils/module.py 90.00% <50.00%> (-2.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omesser omesser temporarily deployed to external July 31, 2023 16:20 — with GitHub Actions Inactive
@omesser
Copy link
Contributor Author

omesser commented Jul 31, 2023

I forgot about this for a few weeks but came back to this today and fixed the tests, with intention of merging this and releasing to fix #688

@omesser omesser marked this pull request as ready for review July 31, 2023 16:22
@omesser omesser temporarily deployed to external July 31, 2023 21:26 — with GitHub Actions Inactive
@omesser omesser temporarily deployed to external August 1, 2023 10:22 — with GitHub Actions Inactive
@omesser omesser temporarily deployed to external August 23, 2023 13:21 — with GitHub Actions Inactive
@omesser omesser marked this pull request as draft August 23, 2023 14:34
@omesser
Copy link
Contributor Author

omesser commented Aug 24, 2023

Seems that CI is broken (not related to changes here, see example in this test PR)
Will need to look at it separately and come back to this afterwards

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix Fixing bugs (for PRs mostly) requirements Finding requirements and dependencies needed to properly serialize objects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing version collection
1 participant